search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Implement MonadNakadi for IO using global configuration #119

Closed mtesseract closed 6 years ago

mtesseract commented 6 years ago

Implement MonadNakadi for IO. Include functions for producing configuration from environment.

This simplifies quick testing in the REPL and enables simple scripting, without monad transformers.

closes #117

@etorreborre, would you be available for a review?

mtesseract commented 6 years ago

We can use your suggestion for the module name. I would not consider it to be that unsafe, though. :-) Cool, I will update the PR (just changing the module name) and go ahead with merging if that is fine for you!

mtesseract commented 6 years ago

Ok, I have added a few more changes:

Neither changes to the actual instance definition, nor to the definition of the two functions for setting the global config.

Will merge! Thanks!