Support partition compaction key

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker

Other

13 stars 9 forks source link

Support partition compaction key #126

Closed rbobin closed 6 years ago

rbobin commented 6 years ago

Closes #125

etorreborre commented 6 years ago

👍

mtesseract commented 6 years ago

Hi, thanks! Right now I cannot give an appropriate review for this. But from first glance the code looks good. I am not familiar with this new feature. But since there is additional review let's merge this. Can you add a version bump please? Thanks!

rbobin commented 6 years ago

@mtesseract sure thing, I will add it. You can find more info about this feature here

mtesseract commented 6 years ago

Thanks. Should we also add support for this cleanup_policy field then?

rbobin commented 6 years ago

Good idea :)

mtesseract commented 6 years ago

As part of this pr or separately? Feel free to choose.

rbobin commented 6 years ago

@mtesseract added CleanupPolicy, however some new tests covering this functionality are still missing