search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Pluggable http backends #39

Closed mtesseract closed 6 years ago

mtesseract commented 6 years ago

This is for easier testing.

Especially the bug about not calling the request modifier on streaming can easily be turned into a test case when the Http Backend can be replaced with a dummy.

@etorreborre @vitold, maybe you would like to have a look at this.

etorreborre commented 6 years ago

Very nice, I will rebase my PR and do testing on top of that!

mtesseract commented 6 years ago

Cool, I will merge this then to master.

etorreborre commented 6 years ago

@mtesseract could you please try a similar test with this pluggable backend which reproduces what happens when streaming events?

Basically in my tests the first response I create seem to be used to create the conduit but this conduit never returns even if the body of the resource is finite. I don't understand how to properly simulate getting events for a subscription