search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

`runSubscriptionR`: incorrect reuse of type parameter #40

Closed etorreborre closed 6 years ago

etorreborre commented 6 years ago

I noticed an issue here:

runSubscriptionR ::
  (Monad m, MonadBaseControl IO m, MonadResource m, MonadReader r m, L.HasNakadiConfig r Config)
  => SubscriptionEventStream -- ^ Connection information for the Subscription
  -> ConduitM ()
              Void
              (ReaderT SubscriptionEventStreamContext m)
              r              -- ^ Subscription Conduit to run
  -> m r

We are forcing the conduit and the final value to return r which is the type parameter bound for the configuration. I will try to do a PR for this.

mtesseract commented 6 years ago

This is of course non-sense. :-) Thanks for noticing.