mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Fix event threshold configuration for smart cursor committing strategy #89

Closed mtesseract closed 6 years ago

mtesseract commented 6 years ago

For completeness, there is one problem with the current implementation: The smart committer (everybody should use this, should become the default at some point) derives its threshold from "maxUncommittedEvents".

What to do if that is Nothing? Currently it just picks some default, which is wrong, because this is not compatible with the actual configuration of the stream consumption.

So, everyhing should be sound if you use the smart committer PLUS you have explicitely set maxUncommittedEvents to some value, preferably large.