search

mtesseract / nakadi-client

Haskell Client Library for the Nakadi Event Broker
Other
13 stars 9 forks source link

Unliftio migration and remove low-level streaming API #93

Closed mtesseract closed 6 years ago

mtesseract commented 6 years ago

Preperation for upcoming changes regarding concurrency. This PR makes nakadi-client adopt the new unliftio foundation and removes the deprecated (by Nakadi) low-level streaming API. See https://zalando.github.io/nakadi/manual.html#/event-types/name/events_get.

mtesseract commented 6 years ago

@etorreborre, could you have a look when you find the time? :-)

etorreborre commented 6 years ago

It looks good to me. Apparently you are also cleaning some of the imports, or it is to make the compilation pass with updated dependencies?

mtesseract commented 6 years ago

It was not really my intention to clean up imports, primarily it was simply directed by the compiler errors. :-) (Not saying that this is not a good idea to be done!)

mtesseract commented 6 years ago

Thanks for the review. If you are fine with this, then I will continue with merging.

etorreborre commented 6 years ago

Yes, 👍