search

mtex-toolbox / mtex

MTEX is a free Matlab toolbox for quantitative texture analysis. Homepage:
http://mtex-toolbox.github.io/
GNU General Public License v2.0
278 stars 183 forks source link

Adding Bain groups to the variant calculation #1818

Closed AzdiarGazder closed 1 year ago

AzdiarGazder commented 1 year ago

Hi Mtex maintainers,

I've introduced the computation of the Bain groups in MTex's variant calculations. Hope you approve of the changes to the following 3 files:

  1. EBSDAnalysis/@parentGrainReconstructor/parentGrainReconstructor.m
  2. EBSDAnalysis/@parentGrainReconstructor/calcVariants.m
  3. geometry/misorientation/calcVariantId.m

Warm regards, Azdi

ralfHielscher commented 1 year ago

Hi Azdiar,

thank you very much for your contribution. Would it be possible to add the new functionality to the documentation as well?

Have a look for example at https://mtex-toolbox.github.io/MartensiteVariants.html I'm not so sure whether this would become too long when adding the Bain groups. In this case we need to make a separate page. I would prefer if the documentation would also include the definition of the bain groups and some reference to textbooks or internet resources where they are explained in more detail.

All the best,

Ralf.

AzdiarGazder commented 1 year ago

Hi Frank and Ralf,

Yay! I'm glad you two approve of the changes. Sure thing - please give me a few days to work on it.

Warm regards, Azdi