search

mtfuller / os-team-project

This is the main repository for the OS Team Project for CS 3502.
0 stars 0 forks source link

Loader is ready *fingers crossed* #7

Closed ghost closed 8 years ago

ghost commented 8 years ago

The Loader requires a Disk as input. I have a basic Disk class to test this. Let me know if I should upload that as well.

mtfuller commented 8 years ago

Definitely will take a look at it. I did force a merge onto the master as an initial project we could all work on. I'm not sure if it will be an issue when we merge the two together.

ghost commented 8 years ago

I hope I haven't messed up anything - I pushed a newer version of Loader() that has commented out the nonexistant classes/objects. Do I need to create a new pull request?

mtfuller commented 8 years ago

You do not. I can approve the changes directly.

ghost commented 8 years ago

That's its parameter - we can just wait to merge this until a disk has been created. Otherwise, the class doesn't accomplish anything. I may need to rewrite this class once I see the disk, actually.

Can this pull request be deleted?

mtfuller commented 8 years ago

That's true. I guess you are right that we should wait until the Disk is created. I'll see if I can close the pull request.

mtfuller commented 8 years ago

I closed the pull request, but we can reopen it when we need to merge the branch in.