mtgatool / mtgatool-desktop

https://mtgatool.com
GNU General Public License v3.0
89 stars 5 forks source link

Fix #16 order by winrate does not work #30

Closed Dunkhan closed 2 years ago

Dunkhan commented 2 years ago

The issue here was that the decks list show aggregated data over all versions of the deck. But the sort was sorting based on only the latest hash for that deck. This means the sort order and the winrate values displayed did not match up.

There are two ways to correct this:

  1. Keep the current aggregated display, and change the sort order to match
  2. Keep the current latest hash sort order, and change the display to match

I went with 1 for this PR. Please let me know if you prefer it the other way around.

https://github.com/mtgatool/mtgatool-desktop/issues/16