mtgjson / mtgjson-website

MTGJSON Documentation Front-End Application built with VitePress
https://mtgjson.com
MIT License
37 stars 25 forks source link

Description of Side field is misleading #514

Closed zqft9001 closed 2 years ago

zqft9001 commented 2 years ago

The description for the side field reads as follows:

"The identifier of the card side. Used on cards with multiple faces."

This is misleading as there are cards with multiple printed faces in the same set that are not dual faced cards, and this field does not account for those (e.x. Icatian Javelineers' Fallen Empires printings, B.F.M, Sly Spy). It does however account for cards with aftermath and other split cards, in addition to DFCs.

Proposed new description:

"The identifier of the card side. Used on cards with multiple faces on the same card."

The current description can be found in the below:

https://mtgjson.com/data-models/card-atomic/#side https://mtgjson.com/data-models/card-token/#side https://mtgjson.com/data-models/card-deck/#side https://mtgjson.com/data-models/card-set/#side

aaronmallen commented 2 years ago

Thanks @zqft9001

staghouse commented 2 years ago

Deployed