mtgjson / mtgjson-website

MTGJSON Documentation Front-End Application built with VitePress
https://mtgjson.com
MIT License
36 stars 24 forks source link

Missing property on Identifiers typing #627

Closed Horsty80 closed 6 months ago

Horsty80 commented 7 months ago

There is the Identifiers typing on the docs:

https://mtgjson.com/data-models/identifiers/#identifiers

export type Identifiers = {
  cardKingdomEtchedId?: string;
  cardKingdomFoilId?: string;
  cardKingdomId?: string;
  cardsphereId?: string;
  mcmId?: string;
  mcmMetaId?: string;
  mtgArenaId?: string;
  mtgjsonFoilVersionId?: string;
  mtgjsonNonFoilVersionId?: string;
  mtgjsonV4Id?: string;
  mtgoFoilId?: string;
  mtgoId?: string;
  multiverseId?: string;
  scryfallId?: string;
  scryfallOracleId?: string;
  scryfallIllustrationId?: string;
  tcgplayerProductId?: string;
  tcgplayerEtchedProductId?: string;
};

And here an example of json response for a specific card

  "identifiers": {
    "cardKingdomId": "122719",
    "cardsphereFoilId": "19",
    "cardsphereId": "20",
    "mcmId": "16165",
    "mcmMetaId": "156",
    "mtgjsonFoilVersionId": "b7c19924-b4bf-56fc-aa73-f586e940bd42",
    "mtgjsonV4Id": "ad41be73-582f-58ed-abd4-a88c1f616ac3",
    "mtgoFoilId": "27501",
    "mtgoId": "27500",
    "multiverseId": "130550",
    "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
    "scryfallId": "7a5cd03c-4227-4551-aa4b-7d119f0468b5",
    "scryfallIllustrationId": "be2f7173-c8b7-4172-a388-9b2c6b3c16e5",
    "scryfallOracleId": "fc2ccab7-cab1-4463-b73d-898070136d74",
    "tcgplayerProductId": "15032"
  }

We can see 2 properties there are missing from the typing

I don't know if other properties are missing, but I think the typing expose in the doc is not up to date