mtgjson / mtgjson-website

MTGJSON Documentation Front-End Application built with VitePress
https://mtgjson.com
MIT License
36 stars 24 forks source link

Issues with CardToken data model #651

Open grim7reaper opened 3 weeks ago

grim7reaper commented 3 weeks ago

Version(s) tested against

MTGJSON 5.2.2+20240816

Description of Bug

Unexpected edhrecSaltiness property

Unexpected edhrecSaltiness?: number; property

Example from AllPrintings.json:

{
  "artist": "Dmitriy Mironov",
  "artistIds": [ "5e48aa5c-60e2-41fe-a7a9-cbed791fdee8" ],
  "availability": [ "paper" ],
  "borderColor": "black",
  "colorIdentity": [ "W" ],
  "colors": [ "W" ],
  "edhrecSaltiness": 0.38,
  "finishes": [ "nonfoil" ],
  "frameVersion": "2015",
  "hasFoil": false,
  "hasNonFoil": true,
  "identifiers": {
    "mtgjsonV4Id": "5778f779-0f54-5b7f-83a3-31491f18d5a9",
    "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
    "scryfallId": "aa796e45-1d95-44f7-927d-0cdd2f67da78",
    "scryfallIllustrationId": "c48e0331-a14a-4d16-bf87-e53c4a001ce5",
    "scryfallOracleId": "d74a5638-83cc-480b-bb02-caecc6a8ff2e"
  },
  "language": "English",
  "layout": "token",
  "name": "Space Marine Devastator",
  "number": "5",
  "power": "3",
  "reverseRelated": [],
  "securityStamp": "triangle",
  "setCode": "T40K",
  "subtypes": [ "Astartes", "Warrior" ],
  "supertypes": [],
  "text": "When Space Marine Devastator enters the battlefield, destroy up to one target artifact or enchantment.",
  "toughness": "3",
  "type": "Token Creature — Astartes Warrior",
  "types": [ "Token", "Creature" ],
  "uuid": "6367ef3e-ca9b-5df6-9803-9c9e2fb7fea8"
}

Unexpected manaCost property

Unexpected manaCost?: string; property

Example from AllPrintings.json:

{
  "artist": "Vincent Christiaens",
  "artistIds": [ "31b01a73-d14f-4f9e-a5dc-9cee3b036124" ],
  "availability": [ "paper" ],
  "borderColor": "black",
  "colorIdentity": [ "W" ],
  "colors": [ "W" ],
  "finishes": [ "nonfoil", "foil" ],
  "frameVersion": "2015",
  "hasFoil": true,
  "hasNonFoil": true,
  "identifiers": {
    "mcmId": "777546",
    "mcmMetaId": "436847",
    "mtgjsonV4Id": "dc6c55cb-1053-5f19-8256-58bffba4c3da",
    "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
    "scryfallId": "31c977b7-12cb-4e6f-8260-a7399b60940f",
    "scryfallIllustrationId": "4dd26100-f7c6-4698-b135-40c153469fb8",
    "scryfallOracleId": "62428d4a-beaa-4124-95ad-a7228e4450cc"
  },
  "keywords": [ "Valiant" ],
  "language": "English",
  "layout": "token",
  "manaCost": "{W}",
  "name": "Flowerfoot Swordmaster",
  "number": "1",
  "power": "1",
  "reverseRelated": [],
  "setCode": "TBLB",
  "subtypes": [ "Mouse", "Soldier" ],
  "supertypes": [],
  "text": "Valiant — Whenever this creature becomes the target of a spell or ability you control for the first time each turn, Mice you control get +1/+0 until end of turn.\n(This token's mana cost is {W}.)",
  "toughness": "1",
  "type": "Token Creature — Mouse Soldier",
  "types": [ "Token", "Creature" ],
  "uuid": "e0711851-a9c9-59a1-94c7-ff70ddc0d4ca"
}

Unexpected flavorName property

Unexpected flavorName?: string; property

Example from AllPrintings.json:

{
  "artist": "Simon Dominic",
  "artistIds": [ "b0e80135-db5a-4b88-a0bc-815a0e94faa1" ],
  "availability": [ "paper" ],
  "borderColor": "black",
  "colorIdentity": [ "B" ],
  "colors": [ "B" ],
  "finishes": [ "nonfoil", "foil" ],
  "flavorName": "The Black Beast of Aaargh",
  "flavorText": "\"Run away! Run away!\"",
  "frameEffects": [ "legendary" ],
  "frameVersion": "2015",
  "hasFoil": true,
  "hasNonFoil": true,
  "identifiers": {
    "mtgjsonV4Id": "cef0d9f1-e0c3-5a28-8d71-85ab03afb1f3",
    "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
    "scryfallId": "a5dd2627-3118-4643-83e2-4637f8821ab4",
    "scryfallIllustrationId": "882ee6db-a3b6-4f6c-8c26-18ec5766a675",
    "scryfallOracleId": "48e9147e-59f7-4693-83d7-7f514be871bc",
    "tcgplayerProductId": "560668"
  },
  "isReprint": true,
  "keywords": [ "Flying", "Indestructible" ],
  "language": "English",
  "layout": "token",
  "name": "Marit Lage",
  "number": "1681",
  "power": "20",
  "relatedCards": {
    "reverseRelated": [ "Dark Depths", "Marit Lage's Slumber" ]
  },
  "reverseRelated": [ "Dark Depths", "Marit Lage's Slumber" ],
  "setCode": "SLD",
  "subtypes": [ "Avatar" ],
  "supertypes": [ "Legendary" ],
  "text": "Flying, indestructible",
  "toughness": "20",
  "type": "Token Legendary Creature — Avatar",
  "types": [ "Token", "Creature" ],
  "uuid": "7499c3c7-8227-53a6-828e-788bcde1fa47"
}

Unexpected isOversized property

Unexpected isOversized?: boolean; property

Example from AllPrintings.json:

"tcgplayerGroupId": 3047,
"tokenSetCode": "TCLB",
"tokens": [
  {
    "availability": [ "paper" ],
    "borderColor": "black",
    "colorIdentity": [],
    "colors": [],
    "finishes": [ "nonfoil" ],
    "frameVersion": "2015",
    "hasFoil": false,
    "hasNonFoil": true,
    "identifiers": {
      "mtgjsonV4Id": "73a96e30-338c-5782-833a-efe4ab8a50ef",
      "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
      "scryfallId": "a9d56324-8293-4500-a9ad-fed351ccf966",
      "scryfallOracleId": "06b9590d-01bf-4fae-9837-352c9e04267a"
    },
    "isOversized": true,
    "isPromo": true,
    "keywords": [ "Crash Landing", "Goad", "Scry", "Treasure" ],
    "language": "English",
    "layout": "normal",
    "name": "Baldur's Gate Wilderness",
    "number": "0",
    "reverseRelated": [],
    "setCode": "TCLB",
    "subtypes": [],
    "supertypes": [],
    "text": "Crash Landing — Search your library for a basic land card, reveal it, put it into your hand, then shuffle.\nGoblin Camp — Create a Treasure token.\nEmerald Grove — Create a 2/2 white Knight creature token.\nAuntie's T
  — Scry 3.\nDefiled Temple — You may sacrifice a permanent. If you do, draw a card.\nMountain Pass — You may put a land card from your hand onto the battlefield.\nEbonlake Grotto — Create two 1/1 blue Faerie Dragon creature token
  lying.\nGrymforge — For each opponent, goad up to one target creature that player controls.\nGithyanki Crèche — Distribute three +1/+1 counters among up to three target creatures you control.\nLast Light Inn — Draw two cards.\nR
  Tollhouse — Roll 2d4 and create that many Treasure tokens.\nMoonrise Towers — Instant and sorcery spells you cast this turn cost 3 less to cast.\nGauntlet of Shar — Each opponent loses 5 life.\nBalthazar's Lab — Return up to two
  creature cards from your graveyard to your hand.\nCircus of the Last Days — Create a token that's a copy of one of your commanders, except it's not legendary.\nUndercity Ruins — Create three 4/1 black Skeleton creature tokens wi
  e.\nSteel Watch Foundry — You get an emblem with \"Creatures you control get +2/+2 and have trample.\"\nAnsur's Sanctum — Reveal the top four cards of your library and put them into your hand. Each opponent loses life equal to t
  ds' total mana value.\nTemple of Bhaal — Creatures your opponents control get -5/-5 until end of turn.",
    "type": "Dungeon",
    "types": [ "Dungeon" ],
    "uuid": "e5d042b4-3ce3-5aed-a1f4-5521484e37da"
  }
]
ZeldaZach commented 3 weeks ago

All of these seem like documentation issues, will move to that repo