mtgjson / mtgjson-website

MTGJSON Documentation Front-End Application built with VitePress
https://mtgjson.com
MIT License
36 stars 24 forks source link

Issues with CardSet data model #652

Open grim7reaper opened 3 weeks ago

grim7reaper commented 3 weeks ago

Version(s) tested against

MTGJSON 5.2.2+20240816

Description of Bug

I've found the following mismatches between the documentation of CardSet and the data in AllIdentifiers.json

grim7reaper commented 3 weeks ago

Also, some cards have neither manaValue nor convertedManaCost while both of them are marked as non optional. e.g., Inkling (again) is one of them.

"00093ed9-5b6b-5a88-bd12-7c3e260abf1c": {
  "artist": "Scott Murphy",
  "artistIds": [ "07c7ac65-dfa6-4273-9c66-ec9d8f3e2226" ],
  "availability": [ "paper" ],
  "borderColor": "black",
  "colorIdentity": [ "B", "W" ],
  "colors": [ "B", "W" ],
  "finishes": [ "nonfoil", "foil" ],
  "frameVersion": "2015",
  "hasFoil": true,
  "hasNonFoil": true,
  "identifiers": {
    "mtgjsonV4Id": "1cdc8eef-d7a8-55bf-999e-4ddb9889cf3e",
    "scryfallCardBackId": "0aeebaf5-8c7d-4636-9e82-8c27447861f7",
    "scryfallId": "f602f9b0-a492-483f-9326-a06a0a63d047",
    "scryfallIllustrationId": "83fe2e6b-9b4d-4937-bd9f-9990e183e0ff",
    "scryfallOracleId": "fbdbff76-c1ea-47ea-bfcc-7c64c23dad70"
  },
  "isReprint": true,
  "keywords": [ "Flying" ],
  "language": "English",
  "layout": "token",
  "name": "Inkling",
  "number": "7",
  "power": "2",
  "relatedCards": {
    "reverseRelated": [
      "Blot Out the Sky",
      "Combat Calligrapher",
      "Dramatic Finale",
      "Fain, the Broker",
      "Felisa, Fang of Silverquill",
      "Inkling Summoning",
      "Inkshield",
      "Mascot Exhibition",
      "Shadrix Silverquill",
      "Umbral Juke"
    ]
  },
  "reverseRelated": [
    "Blot Out the Sky",
    "Combat Calligrapher",
    "Dramatic Finale",
    "Fain, the Broker",
    "Felisa, Fang of Silverquill",
    "Inkling Summoning",
    "Inkshield",
    "Mascot Exhibition",
    "Shadrix Silverquill",
    "Umbral Juke"
  ],
  "setCode": "TBRC",
  "subtypes": [ "Inkling" ],
  "supertypes": [],
  "text": "Flying",
  "toughness": "1",
  "type": "Token Creature — Inkling",
  "types": [ "Token", "Creature" ],
  "uuid": "00093ed9-5b6b-5a88-bd12-7c3e260abf1c"
}

=> no legalities, purchaseUrls, rarity, manaValue nor convertedManaCost But a non-documented (and deprecated I guess)reverseRelated property.

ZeldaZach commented 3 weeks ago

Looks like a documentation problem, will transfer to that repo