mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
545 stars 102 forks source link

Phoenix Heart #250

Closed taw closed 5 years ago

taw commented 7 years ago

If http://mtgsalvation.gamepedia.com/Proposal and http://mtgsalvation.gamepedia.com/Splendid_Genesis are treated as cards, then http://mtgsalvation.gamepedia.com/Phoenix_Heart should probably be as well.

gwax commented 6 years ago

Phoenix Heart does not show up in magiccards.info, which is where the rest of this set is pulled from. Until there is an upstream to draw upon, mtgjson cannot provide the card.

taw commented 6 years ago

@gwax MCI is barely maintained, so it needs to be fixed here if anywhere.

gwax commented 6 years ago

mtgjson scrapes, normalizes and aggregates data from elsewhere

whether it is MCI or somewhere else, there needs to be somewhere that the data is scraped from.

silasary commented 6 years ago

Scryfall has this data, under pcel. Seems like a point of favor towards #412

ZeldaZach commented 6 years ago

I'd like support for this added, if it has to be done by a C.js edit, then so be it.

silasary commented 6 years ago

I could send a PR that defines Phoenix Heart and potentially Gleemox in C.js, if you think that's ideal. (Although I'm not a fan of defining entire cards with corrections)

gwax commented 6 years ago

@silasary I don't think it's ideal but I think it's the most practical solution for right now.

gwax commented 6 years ago

Phoenix Heart would want to be added to the pCEL config json: https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/promo/pCEL.json

And Gleemax would want to be in UNH config json: https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/un/UNH.json

silasary commented 6 years ago

Gleemox, not gleemax. (Entirely different card).

And it would probably want to go somewhere with other Magic Online Promo cards (If we had them).

fenhl commented 6 years ago

@gwax: Gleemox is a MTGO-only promo un-card, not to be confused with Gleemax from Unhinged (which is on Gatherer and thus in MTG JSON already).

ZeldaZach commented 6 years ago

I know we have mtgo-only sets in JSON... did we miss that promotional set somehow?

gwax commented 6 years ago

TIL.

Then, I'd be inclined to say that Gleemox should probably get its own set config in the the un folder.

gwax commented 6 years ago

Or, maybe pMGTO for online-only promos

KingSupernova31 commented 5 years ago

Fixed in v4.