Closed taw closed 5 years ago
Phoenix Heart does not show up in magiccards.info, which is where the rest of this set is pulled from. Until there is an upstream to draw upon, mtgjson cannot provide the card.
@gwax MCI is barely maintained, so it needs to be fixed here if anywhere.
mtgjson scrapes, normalizes and aggregates data from elsewhere
whether it is MCI or somewhere else, there needs to be somewhere that the data is scraped from.
Scryfall has this data, under pcel. Seems like a point of favor towards #412
I'd like support for this added, if it has to be done by a C.js edit, then so be it.
I could send a PR that defines Phoenix Heart and potentially Gleemox in C.js, if you think that's ideal. (Although I'm not a fan of defining entire cards with corrections)
@silasary I don't think it's ideal but I think it's the most practical solution for right now.
Phoenix Heart would want to be added to the pCEL config json: https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/promo/pCEL.json
And Gleemax would want to be in UNH config json: https://github.com/mtgjson/mtgjson/blob/master/shared/set_configs/un/UNH.json
Gleemox, not gleemax. (Entirely different card).
And it would probably want to go somewhere with other Magic Online Promo cards (If we had them).
@gwax: Gleemox is a MTGO-only promo un-card, not to be confused with Gleemax from Unhinged (which is on Gatherer and thus in MTG JSON already).
I know we have mtgo-only sets in JSON... did we miss that promotional set somehow?
TIL.
Then, I'd be inclined to say that Gleemox should probably get its own set config in the the un
folder.
Or, maybe pMGTO
for online-only promos
Fixed in v4.
If http://mtgsalvation.gamepedia.com/Proposal and http://mtgsalvation.gamepedia.com/Splendid_Genesis are treated as cards, then http://mtgsalvation.gamepedia.com/Phoenix_Heart should probably be as well.