search

mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
547 stars 102 forks source link

Missing cards from Happy Holidays #318

Closed vanyamil closed 6 years ago

vanyamil commented 7 years ago

Goblin Sleigh Ride and Thopter Pie Network (Happy Holidays promo cards for 2015 and 2016) are missing in the database.

Garbee commented 7 years ago

These aren't even playable nor generally available. Why should they be included in the DB?

dgant commented 7 years ago

Because anyone who builds on top MTGJSON and wants to include these cards will have to re-implement them on their own. ComboDeck users search for holiday/fun cards fairly often.

You can buy Thopter Pie Network for $23 on TCGPlayer.

vanyamil commented 7 years ago

For example, I'm running stats on the Magic Bracket using this DB and I just can't do anything about those two cards because both Cards-x and Sets-x stop at 2014 for pHHO.

Ivan

On Mon, Apr 10, 2017 at 12:54 PM, Dan Gant notifications@github.com wrote:

Because anyone who builds on top MTGJSON and wants to include these cards will have to re-implement them on their own. Anecdotally, ComboDeck users search for holiday/fun cards fairly often.

You can buy Thopter Pie Network for $23 on TCGPlayer.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mtgjson/mtgjson/issues/318#issuecomment-293011025, or mute the thread https://github.com/notifications/unsubscribe-auth/AQJ1fouZnFKoW0xFJfHNpAI4BJA4NMTOks5rul7MgaJpZM4M4InQ .

fenhl commented 7 years ago

Goblin Sleigh Ride has been added now. Thopter Pie Network is still missing.

ZeldaZach commented 6 years ago

Added in V4 (HHO)