search

mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
548 stars 102 forks source link

Basic land cards are all rarity "Basic Land" even when they're promos #462

Open taw opened 7 years ago

taw commented 7 years ago

I fixed them manually for mtg.wtf.

Affected sets - all basic lands in these:

These are clearly promo cards and not of "basic land" rarity in any meaningful sense.

silasary commented 7 years ago

Note that the rarity of basic lands for earlier sets are also not "Basic Land". (Including but not limited to the Island on the Alpha rare sheet)

taw commented 7 years ago

Here's what wiki says about print sheets. No idea how reliable this is.

Cases like troll rare Island we probably could just ignore.

fenhl commented 7 years ago

Rarity as currently defined on Gatherer should be considered separately from actual sheet rarity, since the former is what determines legality in formats such as Pauper. A separate field for sheet rarity has been proposed in the past, but would have to be maintained manually.

lincolnthree commented 7 years ago

I'm in favor of leaving this as-is. There are other, more reliable, ways to identify promos, such as setcode. And this data, as mentioned, is extremely important for calculating Pauper legality.

taw commented 7 years ago

None of these promo sets are on Gatherer, or relevant for Pauper.

ZeldaZach commented 6 years ago

Basics have always had the basic land rarity, and even if promo'd, i see no reason to change it...

taw commented 6 years ago

What do you mean by that?

Some of them rare symbol printed on them

And in terms of print sheets, there's been a ton of exceptions - many sets had basics printed on common sheets, and some sets (DGM, FRF, ME4) had non-basics printed on what's normally a basic land sheet.

Gatherer weirdly does this too for just one set.

ZeldaZach commented 6 years ago

Hmm... Maybe we can look into addressing this then