mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
545 stars 102 forks source link

Include number of cards in each set #551

Closed tooomm closed 5 years ago

tooomm commented 6 years ago

Could be a new "cards": "196" field in the set_configs of each set: They are not filled automatically and one need to change them by hand anyway, right?

The value should carry over to the mtgjson files, too:

"ZEN": {
    "name": "Zendikar",
    "code": "ZEN",
    "magicCardsInfoCode": "zen",
    "releaseDate": "2009-10-02",
    "border": "black",
    "type": "expansion",
    "block": "Zendikar",
    "cards": "249"
    "booster": [
      [
        "rare",
        "mythic rare"
      ],
      "uncommon",

...

The amount of cards in each set is available on the product pages from wizards: https://magic.wizards.com/en/game-info/products/card-set-archive/zendikar

This would allow downstream projects to e.g. handle cards with a card number bigger than the number of cards in a set differently. For example discard them, group them in a special sub-set, allow users of a webpage or database to filter them out etc.pp.


Wizards itself clearly state on the official product page for Rivals of Ixalan that the set has 196 cards only! When you click on the link to the list of RIX cards there, it'll also only show the normal cards: https://magic.wizards.com/en/products/rivals-ixalan

Cards like Angrath's Fury or Angrath's Ambusher which have card numbers greater than 196 are NOT listed there. They are only printed for and contained in the preconstructed Planeswalker Decks for this set.

mtgjson has these as RIX cards because gatherer as our source does so too. But most people are not too interested in them because they are not relevant for limited and constructed basically. Including a way to deal with these cards would be nice!

ZeldaZach commented 6 years ago

I don't see a good reason for this change, can you possibly explain uses?

fenhl commented 6 years ago

I think a field on the card that says whether or not it can appear in boosters would be more helpful.

tooomm commented 6 years ago

That is also an interesting option @fenhl 👍

magreenblatt commented 6 years ago

I would also like this (either the max "number" for booster cards, or a flag on the specific cards in excess of the max number). For example, to know that "Will Kenrith" (number 255) and "Rowan Kenrith" (number 256) from BBD are not available in boosters.

ZeldaZach commented 5 years ago

More discussions in https://github.com/mtgjson/mtgjson4/issues/48