search

mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
545 stars 102 forks source link

Missing Foreign Limited & Unlimited Edition #579

Closed sebastiandine closed 5 years ago

sebastiandine commented 6 years ago

Europe specific sets like Foreign Black and White Bordered as well as Renaissance, are missing.

silasary commented 6 years ago

Duplicate of #295

tooomm commented 6 years ago

Is it @silasary? Doesn't #295 only speak about renaissance?

sebastiandine commented 6 years ago

Correct, it seems like there is no extra issue about foreign black and white bordered. So could we please reopen this issue?

tooomm commented 6 years ago

For completeness, here the reference from the other issue (which should get closed instead I think): https://mtg.gamepedia.com/Renaissance

@sebastiandine maybe you want to rename the issue title as well?

MarkMYoung commented 6 years ago

While the topic of missing foreign sets is being discussed, Salvat 2005 and Salvat 2011 are also missing (https://mtg.gamepedia.com/Salvat). The cards were printed in Spanish, French, and Italian, but I'm not sure about the exact breakdown by set or card even. I have over 20 cards from Salvat 2005 but cannot inventory them because the app. I use references this project.

ancestral commented 6 years ago

@MarkMYoung That’s not a set, though. Wouldn’t that be promotional? MTGJSON hasn’t cared about most promo releases.

fenhl commented 6 years ago

Missing promos are a bug, not a feature.

ancestral commented 6 years ago

Does that mean you want to also include Sewers of Estark and Shichifukujin Dragon?

fenhl commented 6 years ago

Sure, those are real cards legal in Vintage.

ZeldaZach commented 6 years ago

I want any and all cards ever printed included, so yes @ancestral

ancestral commented 6 years ago

Well, the dragon is definitely not legal, as aren’t quite a few other celebration cards.

There are also digital cards from that Magic Shandalar game. But I think the place to draw the line is if the card name is on Gatherer. (I’m still not sold about worrying about sets not in Gatherer though. Sewers is listed as a promo in Gatherer, but Carrion Rats isn’t.)

ZeldaZach commented 6 years ago

My first goal is to index all gatherer cards. We can have deeper discussions once that is 100% complete. I'd rather not get side-tracked and fall behind my release schedule

ZeldaZach commented 5 years ago

Addressed on V4