search

mtgjson / mtgjson3

MTGJSON repository for Magic Cards
http://mtgjson.com
Other
547 stars 102 forks source link

C18 is missing from AllCards, AllSets-x, and AllSets #608

Closed ancestral closed 6 years ago

ancestral commented 6 years ago

Cards (or at least new cards) from C18 are missing from three of four compiled JSON files.

If you do a search for Yuriko (one of the new commanders from the set) you should see it at least once, but it’s only in one of the four files. The same goes for other new Commander 2018 cards.

ZeldaZach commented 6 years ago

I'm honestly not sure why this is going haywire like this...

tooomm commented 6 years ago

Realized that yesterday already after the update, thought it's some caching issue or that the allsets files needs to get internally created/deployed first after a change.

ZeldaZach commented 6 years ago

It's possible the files didn't get cached yet as cloudflare is being annoying

tooomm commented 6 years ago

How are the allsets, allsets-x, allcards etc. files created btw? As we don't keep them in the repo and don't update them as we do with the others.

Maybe we should start doing so if that solves the issues with big delays?

fenhl commented 6 years ago

Hmm. In version 4 we won't have build artifacts in the repo at all. Since that's not an option for v3 though, I think it would make sense to be consistent and have all of the build artifacts in the repo.

tooomm commented 6 years ago

FYI: The first attempt on v4 by @lsmoura (https://github.com/mtgjson/mtgjson4_temporary) used a separate repo for storing (https://github.com/mtgjson/db) as described here.

KingSupernova31 commented 6 years ago

This is fixed now, right?

ZeldaZach commented 6 years ago

Should be