mtgjson / mtgjson4_temporary

MTGJSON version 4
http://mtgjson.com
2 stars 4 forks source link

Nemesis Set Code #52

Closed dev-id closed 6 years ago

dev-id commented 7 years ago

The set code for Nemesis should be NEM

http://magic.wizards.com/en/articles/archive/ask-wizards-august-2004-2004-08-02

tooomm commented 7 years ago

There might be others too.

Cross referencing interesting comments: https://github.com/mtgjson/mtgjson/issues/182#issuecomment-227214984 https://github.com/mtgjson/mtgjson/issues/156#issuecomment-215835896

CC: @fenhl

fenhl commented 7 years ago

I believe the set codes should be:

For NEM and P02, the Ask Wizards article clearly lists these set codes and there are to my knowledge no official sources contradicting them.

For CM1 and DDL, those are the the set codes used by Gatherer, and the Card Set Archive is known to be incorrect in other instances (e.g. listing Theros as THR, which is contradicted by every other official source, including Gatherer, the set announcement post, and an answer by Matt Tabak). Additionally, CM1 makes more sense as it does not contradict the announced set code of CMA for Commander Anthology, and DDL is more consistent with the other Duel Decks.

tooomm commented 7 years ago

If Nemesis gets finally corrected, we have to update the documentation on the page as well, since the example there is Nemesis: http://mtgjson.com/documentation.html

ZeldaZach commented 6 years ago

Addressed the 4 set code corrections

tooomm commented 6 years ago

Maybe leave still open to not forget to adjust the docs later. (I assume it's only addressed in the v4 rewrite for now)

If Nemesis gets finally corrected, we have to update the documentation on the page as well, since the example there is Nemesis: http://mtgjson.com/documentation.html