search

mtgjson / mtgjson4_temporary

MTGJSON version 4
http://mtgjson.com
2 stars 4 forks source link

Color identity formatting is inconsistent with color #56

Closed fenhl closed 6 years ago

fenhl commented 6 years ago

See mtgjson/mtgjson#358.

The "colorIdentity" array uses single letter abbreviations ("W", "U", etc), while the "colors" array uses full words.

We should probably just use full words for both.

taw commented 6 years ago

It's slightly easier to work with single color abbreviations than words, but should be same one way or the other.

KingSupernova31 commented 6 years ago

Yeah, there's no reason they should be inconsistent. It just requires extra work when doing any sort of comparison or sorting.

ZeldaZach commented 6 years ago

It now will work in WUBRG order, for the time being.

tooomm commented 6 years ago

So both, "colorIdentity" and "colors", use single letter abbreviations now?

ZeldaZach commented 6 years ago

That is correct