search

mtgjson / mtgsqlive

MTGJSON build scripts to generate alternative data formats
https://mtgjson.com
MIT License
54 stars 32 forks source link

[MySQL] Errors with paths #25

Closed ancestral closed 5 years ago

ancestral commented 5 years ago

When trying in a path, if it has an extra space at the end, the app complains. If you supply a path to save a .sql file without specifying the name of the file (let's say, a directory to save it to) it complains.

omfgitsmark commented 5 years ago

Well, what do you think the default name for the file should be?

I'm thinking just mtg.sql, thoughts?

EDIT: I can't seem to recreate any problems with having an extra space. Can you provide exact steps?

ZeldaZach commented 5 years ago

mtgjson_4.5.0.sql if possible. Also, the problem is most likely a missing strip() at the end of user parsing. I don't expect spaces to be captured at the end tho... weird

ancestral commented 5 years ago

The name doesn’t matter much to me!

omfgitsmark commented 5 years ago

I think it's all fixed, I added strips to basically everything even though I thought argparse automatically did that. I ended up making the default mtgjson.sql but I'll append the version number on there because that's a good idea.

omfgitsmark commented 5 years ago

pretty sure this can be closed, and I can't close it :(