Open NBKelly opened 1 year ago
look into migrating these to turn-flags and run-flags (or better yet, maybe they can be floating/constant effects?)
I said I added the first TODO but I forgot about these. I hope to remove all of the prevent/lock flags (and all the flags in the general tbh) and convert them to our other systems. You're on the money with constant effects.
There's a few of these that have accumulated over the years
new-game-button
in 'src/cljs/nr/lobby.cljs' - "rewrite this check"load-replay-button
in 'src/cljs/nr/lobby.cljs' - "rewrite this check"game-lobby
in 'src/cljs/nr/lobby.cljs' - "make starting a game from the deckbuilder work again"in
src/clj/web/ws.clj` - multiple go blocks could compete, this might be a source of black screens sometimes. Update/fix this.check-for-inactivity
insrc/clj/web/angel_arena.clj
- maybe make this an option for all games (notify lobby of inactivity before you get booted)ugly-counter-hack
insrc/clj/came/core/engine.clj
- find a way to no longer need this hackderez
insrc/clj/game/core/rezzing.clj
- make this asynchronous (and maybe let it complete an eid too)register-successful-run
insrc/clj/game/core/runs.cljs
- We queue apre-successful-run
event in here, and it's implied we instead want these abilities (sneakdoor/omar) to instead prevent/replace the successful runcard-str
insrc/clj/game/core/to_string.clj
- add naming of scoring area of corp/runnercard-flag?
insrc/clj/game/core/flags.clj
- Add a register for mutable state card flags, separate from thisprevent-draw/jack-out/prevent-current/lock-zone/release-zone
insrc/clj/game/core/flags.clj
- look into migrating these to turn-flags and run-flags (or better yet, maybe they can be floating/constant effects?)find-undefined-locals
insrc/clj/game/macros.clj
- switch to requiring that passage if/when possible, instead of in-lining the functionTrade-In
insrc/clj/game/cards/events.clj
- I'm not sure, but it's demanding attentionHunting Grounds
insrc/clj/game/cards/resources.clj
- when suppression is fixed (has this happened yet?), should be(:ice context)
Jackpot!
insrc/clj/game/cards/resources.clj
- this is async, but it's getting called in move (which is sync) - issue dated oct `20Political Operative
insrc/clj/game/cards/resources.clj
- convert the continue-ability into a cost (also the label says "trash an ice" ???)Bankroll
insrc/clj/game/cards/programs.clj
- Dirty hack for interacting with Jak Sinclair ???If you fix any of these, then link it to this issue.