replace toastr with something more modern - Githubissues

mtgred / netrunner

http://www.jinteki.net

Other

900 stars 393 forks source link

replace toastr with something more modern #7745

Open NBKelly opened 1 month ago

NBKelly commented 1 month ago

Toastr is nice, but it hasn't been updated or touched in the last seven years at all, and it has a few issues:

https://github.com/CodeSeven/toastr/issues/689 - there are XSS vulnerabilities we have to watch out for (currently, I think it's only possible for a user to hurt themselves)
https://github.com/CodeSeven/toastr/issues/698 - names clash with bootstrap

We could potentially look at using something like this in the future:

https://github.com/apvarun/toastify-js/tree/master

NBKelly commented 1 month ago

Could potentially allow us to do fancy stuff like #5727, too.