mtheall / ftpd

FTP Server for 3DS/Switch
GNU General Public License v3.0
1.37k stars 132 forks source link

ftpd not building on latest libnx #184

Closed electrus89 closed 4 months ago

electrus89 commented 4 months ago

Describe the bug A field was removed from a structure included from libnx, causing compilation to fail.

To Reproduce Steps to reproduce the behavior:

  1. Using a DevKitPro environment and libnx library fully up to date and including all required dependencies, run make nro.

Expected behavior Compilation should succeed provided that DevKitPro is installed and properly updated, and all dependencies are installed.

Screenshots No screenshots retained at this time, but I can reproduce the issue with an unmodified version of the code if needed.

Platform (please complete the following information):

Additional context A pull request, #177, has existed since the library updated with the line deletion required. Issue is relating to the deletion of a field that was previously present. I made the same change separately before coming upon this PR and this allows compilation. I haven't confirmed working status for ftpd pro as I have not finished installing everything needed on my Switch to run it. I can work on confirming this if required.

electrus89 commented 4 months ago

Closing as the PR has also been closed pending fix.