mthenw / serverless-go-plugin

⚡️ Serverless Framework plugin that compiles Go functions on the fly. Sponsored by https://cloudash.dev
https://cloudash.dev
MIT License
103 stars 17 forks source link

Support for Package Patterns Syntax #31

Open cturner-confluent opened 2 years ago

cturner-confluent commented 2 years ago

Currently the docs still showing support for package includes, but that is no longer the supported format and should use package patterns instead any way to move to supporting this?

Here is the error output recieved when attempting to use package patterns instead of include exclude

Environment: darwin, node 18.3.0, framework 3.19.0 (local) 3.18.1v (global), plugin 6.2.2, SDK 4.3.2
Docs:        docs.serverless.com
Support:     forum.serverless.com
Bugs:        github.com/serverless/serverless/issues

Error:
TypeError: Patterns must be a string or an array of strings
    at assertPatternsInput (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/globby/index.js:16:9)
    at generateGlobTasks (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/globby/index.js:41:2)
    at module.exports (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/globby/index.js:115:20)
    at Package.resolveFilePathsFromPatterns (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/serverless/lib/plugins/package/lib/package-service.js:278:12)
    at Package.resolveFilePathsFunction (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/serverless/lib/plugins/package/lib/package-service.js:218:17)
    at async Package.packageFunction (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/serverless/lib/plugins/package/lib/package-service.js:179:23)
    at async /Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/serverless/lib/plugins/package/lib/package-service.js:99:9
    at async Promise.all (index 2)
    at async Package.packageService (/Users/cturner/github.com/confluentinc/image-digest-validator/node_modules/serverless/lib/plugins/package/lib/package-service.js:115:5)
danteay commented 1 year ago

will work on this latter