search

mtheoryx / iuwpcas

Wordpress plugin integrating Indiana University CAS Authentication
http://mtheoryx.github.com/iuwpcas
9 stars 5 forks source link

Conflict between plugins on the left-hand menu bar #7

Open patproct opened 12 years ago

patproct commented 12 years ago

A user at IU was having an issue. When she used the CAS plugin with Cforms, only the CAS plugin would show up on the left hand side of the admin page. The final argument on add_menu_page, $position, is set to 100 just like Cforms. I changed this argument in my fork of the plugin and it works. http://codex.wordpress.org/add_menu_page

mtheoryx commented 12 years ago

Well, maybe we should not set the position at all?

It's already at 100, so it's below the core items. Simply moving it to 101 doesn't "really" help because what if another user has a plugin set to that?

I think that leaving it unset, and just having it appear at the bottom (or anywhere) is both easier, and more reliable.

I'd rather have it appear in an uncontrolled position than not appear at all.

Thoughts?

patproct commented 12 years ago

That's probably a good idea. I set it to 101 just to see if that did the trick and I gave not setting it at all some thought. I was on the fence about it. I will go ahead and leave it unset.

mtheoryx commented 12 years ago

Wanna send me a pull request? I can get it merged in and hopefully no one else will have the issue.

Cheers!

patproct commented 12 years ago

Sure, I will send a pull request. I should warn you up front that I have made a few other changes.

mtheoryx commented 12 years ago

No problem. I'm sure it's fine. I'll look at the changes first to double check.