search

mtherien / slntools

Solution Tools for Visual Studio - manages solution files
MIT License
28 stars 14 forks source link

CreateFilterForm.SaveAs directory name comparison issue #5

Closed mtherien closed 6 years ago

mtherien commented 6 years ago

First of all, thanks so much for sharing this tool - I was just about to write some custom code to do this, when I found your project.   Unfortunately I'm not able to use the tool to create a filter file. Here's the problem and the fix:   CreateFilterForm.SaveAs compares the directory names and fails with a message, "Filter file need to be in the same folder as the source solution." For some reason the drive letter is uppercase on one side of the comparison and lowercase in the other side (I'm not sure why, and haven't tried to diagnose).   The fix is to use a case-insensitive comparison, which should be safe since the Windows file system is case insensitive:   string.Equals(Path.GetDirectoryName(Path.GetFullPath(fileDialog.FileName)), Path.GetDirectoryName(Path.GetFullPath(m_filterFile.SourceSolutionFullPath)), StringComparison.InvariantCultureIgnoreCase)   I'd be happy to join as a contributor if you'd like me to fix this directly. For now I've made this change locally in my own copy.  

Keith Brown, CTO Pluralsight

This work item was migrated from CodePlex

CodePlex work item ID: '6218' Vote count: '1'

mtherien commented 6 years ago

[keithbrown42@6/18/2011] Workaround: make sure the drive letter is upper-case if you provide a full path to your solution file. If it's lower-case you'll run into this problem.

mtherien commented 6 years ago

[UnknownUser@3/22/2012] Resolved with changeset 68555.

mtherien commented 6 years ago

[UnknownUser@2/14/2013]

mtherien commented 6 years ago

[UnknownUser@5/16/2013]