mthxx
commented
9 years ago I did large refactor about 2 months ago to make everything more consistant, and created a "NAMING_CONVENTIONS.txt", but to be fair I haven't even really been following it myself very well.
The whole code base could benefit from a clean up and refactor, as well as established and strickly enforced guidelines.
Having a contributing.md file and a CI service running would be very helpful!
I would like to suggest that (upon having an alpha release), A cleanup and refactor step. I suggest addressing (or squelching) as many pylint and pep8 complaints as possible. I would be happy to make these changes to the best of my abilities, but it may be a substantial changes may not merge well, so it may best to wait for a a major release when development can subside from new features for a brief time while the code is refactored. I also wanted to post the pylint and pep8 complaints as current and open a discussion on weather or not conforming to the default (or any) standard would be desirable for stable releases.
Note: The way gi.repository is compiled, it doesn't provide metadata that pylint uses to do linting, so warning about no-memeber of gtk-extended objects is something that has to be ignored.
Reports: https://gist.github.com/thorsummoner/cafd044d70ae6a751ed8
It would also be nice if new code moving forward would stick to these guidelines. I could prepare a
contributing.mdfile as well, as a guide for pre-merge checks, and setup travis CI to run pylint automatically for us.