search

mthxx / Budget

Personal Finance for the Linux desktop.
http://mthx.org/projects/budget/
GNU General Public License v2.0
10 stars 3 forks source link

Logo/Icon #63

Closed mthxx closed 9 years ago

mthxx commented 9 years ago

The logo needs to be swapped out with the new svg logo.

mthxx commented 9 years ago

Works on Arch. Doesn't work on Fedora or Ubuntu. No idea why at the moment.

cassidyjames commented 9 years ago

Where are you installing your icons? I know for elementary OS (and I believe Ubuntu) we expect them to be in /usr/share/icons/hicolor

mthxx commented 9 years ago

I've currently got it installing to "/usr/share/icons/hicolor/scalable/apps/". Here's the relevant file. https://github.com/mthxx/Budget/blob/master/setup.py

I'm currently using a single svg image rather than multiple pixel perfect images which I was thinking might be the problem, but I haven't tested that theory yet.

thorsummoner commented 9 years ago

I believe you can drop svgs in each resolution and they should work, eg you don't need to rasterize them, just to tell the system this svg works at this size On Jul 16, 2015 12:55 PM, "Marc Thomas" notifications@github.com wrote:

I've currently got it installing to "/usr/share/icons/hicolor/scalable/apps/". Here's the relevant file. https://github.com/mthxx/Budget/blob/master/setup.py

I'm currently using a single svg image rather than multiple pixel perfect which I was thinking might be the problem, but I haven't tested that theory yet.

— Reply to this email directly or view it on GitHub https://github.com/mthxx/Budget/issues/63#issuecomment-122070282.

mthxx commented 9 years ago

So this is very weird behavior. I am dropping svg's in each directory for 16, 24, 32, 48, 64, and 128. Running Gnome (Arch), it did not pick up on the icon until I also dropped it in the scalable folder. Running Gnome (Fedora) and Unity (Ubuntu), it did not pick up any of the images.

I am starting to this the problem lies in my .desktop file.

cassidyjames commented 9 years ago

The .desktop looks fine so long as your icons are named budget.svg or budget.png...

mthxx commented 9 years ago

I just tried them as PNG's. Same results across the board. I also just now tested it on KDE (Arch) and it worked just fine. I'll have to spin up a few more VM's later to try it out on different configurations, but clearly I am missing something.

thorsummoner commented 9 years ago

I'm pretty confused by how I haven't ever found good documentation on how to setup icons on Linux, especially icon packs, I've never found any tools to "compile" source svgs into the correct directory structure, and I don't want to believe their assembled by hand still these days. On Aug 6, 2015 9:08 AM, "Marc Thomas" notifications@github.com wrote:

I just tried them as PNG's. Same results across the board. I also just now tested it on KDE (Arch) and it worked just fine. I'll have to spin up a few more VM's later to try it out on different configurations, but clearly I am missing something.

— Reply to this email directly or view it on GitHub https://github.com/mthxx/Budget/issues/63#issuecomment-128420738.

cassidyjames commented 9 years ago

@thorsummoner I just filed a bug against the elementary OS developer guide at https://github.com/elementary/mvp/issues/786 ;)

mthxx commented 9 years ago

Well, I have a workaround for the moment. I've hard coded the path "/usr/share/icons/hicolor/scalable/apps/budget.svg" in the .desktop file. This is not a very good solution though, it is completely ignoring the correctly sized icons for the various views, and also makes it so that users with alternative icons packs in use will be forced to see stock version of the icon. Closing this ticket, but creating a new one (see #76) to fix the hard coding.

mthxx commented 9 years ago

@cassidyjames: The solution to this issue might be relevant to your documentation. I completely resolved this and #76 by also adding the icons to the "Adwaita" folder, in addition to the hicolor folder. Both Ubuntu (Unity) and Fedora (Gnome) picked up the icons immediately in their launchers.