mtierltd / timetracker

GNU Affero General Public License v3.0
82 stars 27 forks source link

Update to NC 25 #192

Closed kralan closed 1 year ago

kralan commented 1 year ago

With NC 25, only the menu is displayed, no client area. Please update TimeTracker to work with NC 25.

annego15 commented 1 year ago

I found a hotfix. Replace the content of the file [nextcloud_html]/custom_apps/timetracker/templates/index.php With the following:

//script('timetracker', "jquery-3.5.1.min");
//script('timetracker', "jquery-3.5.0");
/*
script('timetracker', "kingtable");
script('timetracker', "moment.min");
script('timetracker', "daterangepicker.min");
script('timetracker', "tabulator");
script('timetracker', "Chart.min");
script('timetracker', "select2.min");
style('timetracker', "kingtable");
style('timetracker', "daterangepicker");
style('timetracker', "tabulator");
*/
//style('timetracker', "select2");

//style('files', 'files');
style('timetracker', 'all');
style('timetracker', 'style');
script('timetracker', $script);

?>

<div id="app-navigation">
    <?php print_unescaped($this->inc('navigation/index')); ?>
    <?php print_unescaped($this->inc('settings/index')); ?>
</div>
<div id="app-content" style="padding: 20px;">
    <div id="app-content-wrapper">
        <?php print_unescaped($this->inc($appPage)); ?>
    </div>
</div>

It would be wise to update the app, but I will not create a pull request as I don't know wether it would break the previous versions.

kralan commented 1 year ago

Thank you for your input,, @annego15 ! I tried your solution and it worked for me.

A few observations:

annego15 commented 1 year ago

Thanks @kralan!

I edited my code to now include all the lines and changed the path. However I checked again, in my installation the path is definitely different from yours. It might be due to the fact, that I use docker.

Your observation is correct, I removed the <div id="app"> as it was messing with the overlaying flex div and added the padding because it looks better that way. The padding is definitely something that only became necessary with the new layout, so it would only be needed in NC 25. About the div, I'm not sure if the app would without it work on a lower version of Nextcloud.