search

mtiggelman / SPI-rack

Python drivers for the QuTech SPI-rack
http://qtwork.tudelft.nl/~mtiggelman/
MIT License
5 stars 8 forks source link

Suggestions for D5a_module #1

Closed Rubenknex closed 7 years ago

Rubenknex commented 8 years ago

Ik doe dit maar in het Engels voor als er ooit nog andere mensen iets mee willen doen.

For the D5a_module class it would be nice if there are also methods for reading the spans and values. Also it is probably better if the conversion from volts to DAC values is done inside this module according to the span that is set.

mtiggelman commented 8 years ago

I had the impression that set/get methods are not 'pythonic' so I didn't write them. The spans are stored in a list which is accessible, is indeed smart to also create a list with the current values and maybe add if they're updated or not.

I'm still hesitant with the voltage->bit conversion function. If people are not aware of the round-off error of the DAC, weird jumps might happen in sweeps. Maybe a way to mitigate this a bit is to create a function which gives the user the smallest voltage step size for the set span? Then they can take this into account.

Rubenknex commented 8 years ago

I think that's a good solution, to provide the users with a minimum step that they can create mutliples of for sweeps.

mtiggelman commented 8 years ago

Just added the functions: set_voltage and get_stepsize. Still have to be tested.