search

mtiggelman / SPI-rack

Python drivers for the QuTech SPI-rack
http://qtwork.tudelft.nl/~mtiggelman/
MIT License
5 stars 8 forks source link

Change the file structure to that of a package #6

Closed Rubenknex closed 7 years ago

Rubenknex commented 7 years ago

@mtiggelman Do you agree with making it a pip-installable package?

mtiggelman commented 7 years ago

I like the idea of the pip-installable package. If I see your changes correctly, it will be more of a flat structure like:

setup.py spirack/spi_rack.py spirack/s5i_module.py spirack/d5a_module.py spirack/etc.

Does it make sense to keep the 'drivers' folder in the pip package? This is a folder that people need to find to install the COM port drivers.

Rubenknex commented 7 years ago

@mtiggelman Yes the drivers folder is included in the main spirack folder which will be the package. I could for example try to put some code in the setup.py that automatically installs the drivers, or else just tell the user how to install them manually.

I think I will then add the latest changes and switch to this PR, and move the qcodes wrappers to the qcodes repository.