Should DyMat (and SciPy) be added to install_requires?

mtiller / recon

Web and network friendly simulation data formats

MIT License

8 stars 4 forks source link

Should DyMat (and SciPy) be added to install_requires? #41

Closed tbeu closed 9 years ago

tbeu commented 10 years ago

There is DyMat required which itself requires SciPy.

Unfortunately there is no DyMat-package on PyPi that can be downloaded by the setuptools.
Unfortunately setup.py of DyMat does not list SciPy as requirement.

xogeny commented 10 years ago

This is technically only required for the translation feature. What I propose (as an alternative) is to catch errors when these imports fail and provide a diagnostic explaining the package format.

xogeny commented 10 years ago

One thought...perhaps all the dsres related stuff could be broken out into a separate package (with a greater number of dependencies). This would keep the core recon library small with a minimum of dependencies and then install all the necessary additional bits if someone specifically wanted the dsres translation capabilities? Alternatively, I have a pure Python generated based dsres reader around somewhere that I could integrate...

tbeu commented 10 years ago

Agreed. All dsres related stuff should go to an extra package.