search

mtkennerly / dunamai

Dynamic versioning library and CLI
https://dunamai.readthedocs.io/en/latest
MIT License
312 stars 24 forks source link

Upgrade to python3.6 #27

Closed wwuck closed 2 years ago

wwuck commented 2 years ago

The upgrade to python3.6 allows us to replace the setuptools dependency with the newer packaging library and importlib.metadata from stdlib. importlib_metadata is used as a fallback for python versions <3.8.

I have also run pyupgrade --py36-plus on the code to simplify the upgrade to newer python3.6 syntax. isort is also included to keep imports updated.

I am happy to revert any changes here if they are unwanted (eg. running pyupgrade, isort, etc.)

Fixes #26

mtkennerly commented 2 years ago

Thank you for your PR! Unfortunately, as I mentioned in #26, this isn't something I'm ready to pursue. Feel free to continue the discussion there if you'd like.