Closed mtelka closed 7 months ago
That's good to know, thanks! I've added a note to CONTRIBUTING.md about this.
Wouldn't it be simpler to simply set HOME
in test__version__from_fossil
if it is not set already?
I guess that's probably fine. It may not always be necessary (e.g., user already ran fossil user default ...
, or is on Windows where it's seemingly not required), but it shouldn't hurt anything.
Looking at the patch... will that work when there is no user dunamai
in /etc/passwd
? Sorry for stupid question, I've zero experience with fossil
.
I'm assuming Fossil just takes the env var value as-is, but I'm not sure either. Would you mind giving it a test in your setup?
The
test__version__from_fossil
test fails when there is no home set:Please note that once I provide home (by setting
HOME
to/tmp
) then test complains with this:So user needs to be provided too. It looks like
fossil
is too picky and is unable to callgetuid()
:-). Nomen omen? :-)