Pathologic (1) and Pathologic 2

mtkennerly / ludusavi-manifest

Backup info for PC game saves

MIT License

74 stars 13 forks source link

Pathologic (1) and Pathologic 2 #10

Closed redactedscribe closed 7 months ago

redactedscribe commented 2 years ago

Pathologic 2's <path-to-game>\data is being detected as the data directory for Pathologic 1.

Pathologic 2's \<path-to-game> (Steam): ...\steamapps\common\Pathologic (notice the lack of a "2").

To back up Pathologic 1 would backup irrelevant Pathologic 2 data. Pathologic 1 isn't available on Steam, only Pathologic Classic HD.

Ludusavi 0.11.0

mtkennerly commented 2 years ago

Thanks for reporting this. This is an interesting one:

Ludusavi 0.11.0: Using the new install directory ranking heuristics, the Pathologic folder is seen as an exact match with the game name, so it gets priority (even though Pathologic 2 has a confirmed installDir of Pathologic in the manifest).
Ludusavi 0.10.0: It just looked for the game name as the install folder if there's no explicit installDir.

This would be hard to solve generically. If we just started prioritizing a known installDir over a matching title, then the same issue could happen in the opposite direction with other games. I'll need to think about how to handle this.

redactedscribe commented 2 years ago

Sort of a similar issue for Overwatch and Overwatch 2 (notice that they share the same conf paths). The former is no longer officially accessible (OW2 replaces OW1) and I don't think there's even a way to play it illegitimately (e.g. private servers). Perhaps blacklist the Overwatch (1) manifest to avoid both from appearing?

Edit: Overwatch (1)'s PCGW reads "This product is no longer playable in any capacity. It is covered here for historical reference.". I'm not sure if that's a standard banner and text, but if it is, perhaps it could be used to detect any manifests which also display it?

mtkennerly commented 2 years ago

Thanks for the heads-up. I've removed Overwatch from the manifest.

About the banner, I'm not sure, but I think it might be automatic from being in this category: https://www.pcgamingwiki.com/wiki/Category:Unplayable_games . I think those games should still be in the manifest, though, as long as they're not duplicated with any other/newer versions. Overwatch is a bit special in that the config paths are 100% identical.

redactedscribe commented 2 years ago

I think you're right about that. There's probably a number of games in that list that people still play through some means and would to be able to back up their data.

Thanks for the Overwatch fix!