search

mtkennerly / ludusavi-manifest

Backup info for PC game saves
MIT License
74 stars 13 forks source link

Revert https://github.com/mtkennerly/ludusavi-manifest/commit/89c90c0466c07d5849dce827a1e7000ad3c05c28 #19

Closed sluedecke closed 2 years ago

sluedecke commented 2 years ago 
    Fom https://github.com/mtkennerly/ludusavi/pull/152#issuecomment-1301732359: PCGW has 7 Billion Humans under the ID 1179120942, which gogdb.org says is a package.

I an find no information about the package on gog.com, even the gog api return "no such product", so I assume the PCGW is wrong here and should link to the game itself. So I edited PCGW to link to 2056114425 instead.

Override added in https://github.com/mtkennerly/ludusavi-manifest/commit/89c90c0466c07d5849dce827a1e7000ad3c05c28 can thus be removed.

Originally posted by @sluedecke in https://github.com/mtkennerly/ludusavi-manifest/issues/18#issuecomment-1301746557

sluedecke commented 2 years ago

Sorry for the quite technical entry, but I cannot reopen #18 ... so I kindly request reverting the commit https://github.com/mtkennerly/ludusavi-manifest/commit/89c90c0466c07d5849dce827a1e7000ad3c05c28

sluedecke commented 2 years ago

Also - if it is ok for you - I'd like to have a closer look to the bundle/package situation with Bioshock 2. The overrides are a adequate mechanism to "fix" this on a case by case basis, but maybe there is a simple way which can be automated. Gog quite often offers game bundles which include both the original and a remastered version.

mtkennerly commented 2 years ago

Sure, it's definitely better to update it on PGCW itself when possible. I'll revert it.

Let me know if you can figure out an automated solution.

mtkennerly commented 2 years ago

I'll close this since the revert is done, but we can still use #18 for talking about an automated option.