search

mtkennerly / ludusavi-playnite

Playnite plugin for save backups via Ludusavi
MIT License
141 stars 9 forks source link

Auto-backup feature while playing #26

Closed ANRCorleone closed 2 years ago

ANRCorleone commented 2 years ago

Hello @mtkennerly

I created the feature during the weekend and tested on a few games. Improvements that I can think of are manually deleting a backup - at the moment, just the oldest backup gets deleted while playing the game and max interval is reached. Another one is to allow different backup settings for individual games, this is my first time playing with WPF which is why I didn't do it.

I hope it doesn't have glaring bugs ;) I followed the development style on the project too.

Cheers!

mtkennerly commented 2 years ago

Hi, and thanks for this! Sorry it's taken me a little bit to review it.

At a high level, I think it makes sense for the Playnite plugin to be able to trigger Ludusavi on an interval like this. However, the logic for retaining multiple backups should be in Ludusavi itself rather than in the plugin. There's a ticket for that in the Ludusavi repository: https://github.com/mtkennerly/ludusavi/issues/74 . That way, the Playnite plugin code stays simpler, and any other plugins in the future (as well as Ludusavi itself) all benefit from the same feature.

Are you interested in working on the multiple backup retention feature in the main Ludusavi program? If so, I'd be happy to coordinate on it and provide some guidance. I know it's frustrating to write a lot of code and then find out there's an architectural concern that requires a rewrite, so we could definitely talk through the details to save you any more headache.

ANRCorleone commented 2 years ago

Hello @mtkennerly !

No worries, we all do this during our free time. As for working in the main Ludusavi program, unfortunately I'm starting fulltime work next week and won't have a lot of time to learn some Rust 😄 . If the feature is not in Ludusavi yet on my next longer holiday (which will be a year or so from now), I'd love to work on it. Is it okay if I release this fork to Playnite plugins and delete it once the feature is in Ludusavi? I think there will be quite a few who might want it.

mtkennerly commented 2 years ago

Sure! It's under the MIT license, so you're more than welcome to release it.