search

mtkennerly / ludusavi-playnite

Playnite plugin for save backups via Ludusavi
MIT License
155 stars 10 forks source link

Only 1 backup is created per game #43

Closed Maingron closed 1 year ago

Maingron commented 1 year ago

Apparently, the max-backups per game settings don't work. No matter in which folder I look, I find only 1 backup and the mapping.yaml. I activated the zip compression and changed the default path. Settings see screenshot.

In fact I now fiddled around a bit and the backup process seems bugged somehow. Not sure about the details.

image

mtkennerly commented 1 year ago

Hi! Could you tell me which version of Ludusavi you're using? That particular setting requires Ludusavi 0.14.0 or newer.

Also, it will only create additional backups if the data for the game has changed, so make sure you're updating your save between tests.

When you say the backup seems bugged, what other specific issues are you seeing?

Maingron commented 1 year ago

I was using Ludusavi-Playnite v0.11.0 and Ludusavi v0.13.1. Didn't expect Ludusavi getting an update. Maybe you can implement a version check with a warning. Didn't get around to test extensively, but I'm having 2 backups in one folder now.

Regarding the bugginess: Backups sometimes only got deleted, so I either had 0 or 1 backup per game.

Also sorry for the late response.

mtkennerly commented 1 year ago

There's actually a notification in Playnite for that :) It only triggers once per recommended update, though.

image

Please let me know if you see that issue anymore with the latest version. For the games with 0 backups, do they have a mapping.yaml file? If so, would you mind uploading one of them here?

Maingron commented 1 year ago

Just going through all folders I can find, and, at least for Cities Skylines, which seems to be the only one remaining, there's no files at all, so no mapping.yaml.
However, it's version related. Just didn't see the notification, I guess.
Would a mapping.yaml from a working game help?

mtkennerly commented 1 year ago

If you delete the empty folder for Cities Skylines and back it up again, what happens? If it shows up empty again, then we can get some logs to narrow down the issue. If it ends up with save files, then I think we can consider this fixed :)

Also, after you try the backup again, what does the notification in Playnite say? If something failed, for example, you would see "Backed up saves for ..., , but some saves failed".

Would a mapping.yaml from a working game help?

Nah, that wouldn't narrow it down.

mtkennerly commented 1 year ago

I'm going to close this for now, but let me know if anything changes or if the issue still occurs for new backups of Cities: Skylines.