mtkennerly / ludusavi-playnite

Playnite plugin for save backups via Ludusavi
MIT License
141 stars 9 forks source link

"requiring matching custom entry" and not backing up automatically? #50

Closed Alistair1231 closed 1 year ago

Alistair1231 commented 1 year ago

Hi-Fi Rush detected in Ludusavi, but not automatically backing up after play. When manually clicking backup it shows this message, which makes no sense to me, am I doing something wrong?: image

image

mtkennerly commented 1 year ago

That means the game doesn't have a PC platform set in Playnite. If you open the game details in Playnite, what does the platform field say?

(Ideally, it shouldn't use the platform to determine if it needs a custom entry. I should be able to improve that in the near future.)

Alistair1231 commented 1 year ago

This is what it says:

Hi-Fi Rush ![image](https://user-images.githubusercontent.com/26165288/224083178-bc2e24f0-788c-4ece-b06a-9880475ade84.png)

For comparison here is Isaac, which also doesn't work:

Isaac ![image](https://user-images.githubusercontent.com/26165288/224083301-cbc88dfe-d893-498d-b4fb-bef947779592.png)

Interestingly, I have a custom entry for Forza Horizon 5 which DOES work, and it has no platform at all

Forza ![image](https://user-images.githubusercontent.com/26165288/224084656-1165ee74-a5a7-4162-b92b-acadd68a2396.png)

What seems to fix the issue is either removing all platforms that aren't PC (Windows) or just leaving the Platform blank. I made the following screenshots like so:

  1. starting, then directly stopping the games.
  2. opening notification bar
  3. opening game info
  4. make screenshot
Screenshots with Platform changes ![image](https://user-images.githubusercontent.com/26165288/224085587-42435649-ee23-4333-b2a0-164e71404cfc.png) ![image](https://user-images.githubusercontent.com/26165288/224085893-ae7ed656-fa28-45d8-83ce-eec8a5aa13d1.png)

(Ideally, it shouldn't use the platform to determine if it needs a custom entry. I should be able to improve that in the near future.)

wouldn't it make more sense to check the ludusavi manifest, if it has any entries? Some games e.g. might be on Windows but have no entry in PCGamingWiki and thus ludusavi doesn't know how to back them up. Or alternatively, it could be checked, if there already is a backup, and if there is ignore !IsOnPc(game);

mtkennerly commented 1 year ago

removing all platforms that aren't PC (Windows)

Yeah, that's definitely a bug. The plugin only checks the first platform, when it should check all of them. I'll fix that.

In the meantime, you can add the [Ludusavi] Game: backup tag to those games to force the automatic backups.

wouldn't it make more sense to check the ludusavi manifest, if it has any entries?

Absolutely. The issue is that Ludusavi didn't have a way to export the manifest plus any custom games. The next release of Ludusavi will provide that functionality, and then the plugin can make use of it.

Alistair1231 commented 1 year ago

In the meantime, you can add the [Ludusavi] Game: backup tag to those games to force the automatic backups.

The weird thing is, that I did that. I even added the Platform Backup tag after it didn't work just to see if that would help.

image ![image](https://user-images.githubusercontent.com/26165288/224278071-fda3c0b3-5910-4481-8398-5ab5d83e7eb5.png)

Here is a video demonstrating that the tag doesn't seem to apply.

https://youtu.be/_--H9FNxLz4

mtkennerly commented 1 year ago

Thanks, that's very helpful. I think I see where the bad platform logic is even stopping it from checking the tags.

mtkennerly commented 1 year ago

I just published v0.12.1, which fixes this.