Closed Dasnap closed 10 months ago
mtkennerly
commented
10 months ago Thanks for reporting this. I think I've identified the cause of the crash and released v0.13.1 with a fix. Could you give it a try and see if that also helps with the "previous request" issue? If it still happens, then please provide a copy of your extensions.log as well.
Dasnap
commented
10 months ago I've updated the extension through the Playnite client and unfortunately I still see both the previous request and crashing issue.
I've been jumping between Baldur's Gate 3 and Peglin to see if it's a per-game issue but it doesn't seem to be the case.
Logs after full testing: extensions.log playnite.log Logs generated from the client crash: crash.zip
mtkennerly
commented
10 months ago Hmm, I can't quite tell why it's not working. Could I get a copy of your Playnite\ExtensionsData\72e2de43-d859-44d8-914e-4277741c8208\config.json file as well? I'll try testing with the same plugin configuration.
Dasnap
commented
10 months ago No problem mate.
Let me know if there's anything else you need to know about my Playnite config as a whole. I had an issue in the past with the client where I had Google Drive pointing at the whole directory for a backup which stopped addon updates from properly installing. I don't do this anymore and instead have Syncthing pointed at it.
I don't think that's the issue but it shows some of the oddities that can affect Playnite.
Edit: Just tested with disabling Syncthing just to confirm that it isn't the issue.
mtkennerly
commented
10 months ago Thanks for the extra detail :+1:
Okay, I don't think it has to do with the specific plugin settings. Just based on the error message, it seems like there's a game that doesn't have a name, but I'm not sure how/why that would even happen.
Could you try this custom build? It adds some more logging to extensions.log and a potential fix for the crash.
Dasnap
commented
10 months ago TL;DR I think this fixes it, but I wrote some testing details anyway.
I drag and dropped the new file onto Playnite and it asked to update from 0.13.1 to 0.13.1, which I allowed.
Crashing when changing settings: While the window hangs for a few seconds after a save, the window closes without crashing!
Previous request error: I open and close Baldur's Gate 3 once and it successfully zips and copies 1GB of save data. I then allowed the Google Drive sync to finish to rule that out as a possibility.
I opened and closed BG3 a second time and forgot to make a new save file. Usually it would still throw the usual error at this point anyway but this time it didn't.
I finally launched the game a third time, made a new save, and closed it. This also succeeded in making a backup.
I then quickly tried making a new save for Peglin and this also worked.
Logs if you're curious: extensions.log
mtkennerly
commented
10 months ago Nice! Thanks for testing it out.
The log does confirm that some of the games don't seem to have a name set in the API, somehow. Specifically, they're from the built-in PlayStation library extension. Those games probably wouldn't back up correctly since the Ludusavi plugin currently assumes that the Name field is always set.
I've released v0.13.2 with the fix.
It seems that I can effectively run a single backup before I need to restart Playnite to reset this error and allow another backup to occur.
Playnite extension version v0.13.0 (2023-06-22)
Ludusavi application version v0.20.0 (2023-07-10)
This is a portable version of Playnite that I keep in my Documents directory for easy backups to my home server.
The extension correctly points at Ludusavi, which is proven by the fact that a backup can occur correctly beforehand.
Ludusavi backs up to a Google Drive directory, but I also tested with a normal directory and the same error occurs.
I'd also like to add that saving settings changes to the extension causes Playnite to crash completely.
playnite.log