search

mtkennerly / ludusavi

Backup tool for PC game saves
MIT License
2.66k stars 58 forks source link

Wrap with flatpak not working #358

Open NL-TCH opened 4 months ago

NL-TCH commented 4 months ago

Ludusavi version

v0.24.1

Operating system

Linux

Installation method

Flatpak

Description

The launch command flatpak run com.github.mtkennerly.ludusavi wrap --infer steam --gui -- %command% is not working. When games are launched with this flag the game will not launch

Logs

No response

mtkennerly commented 4 months ago

Hi! Could you share your Ludusavi log file? For Flatpak, it would be: ~/.var/app/com.github.mtkennerly.ludusavi/config/ludusavi/*.log

Also, could you try with a standalone copy of Ludusavi just to rule out any Flatpak-specific issues?

NL-TCH commented 4 months ago

Hi,

the logs are empty (only old logs)

image

can i download ludusavi rpm from somewhere, or do i need to compile it myself?

mtkennerly commented 4 months ago

You can download a standalone executable from the releases page. Here's the latest Linux release:

https://github.com/mtkennerly/ludusavi/releases/download/v0.24.1/ludusavi-v0.24.1-linux.zip

To point it at your Flatpak Ludusavi config, you can add the --config argument:

/path/to/ludusavi --config ~/.var/app/com.github.mtkennerly.ludusavi/config/ludusavi wrap --infer steam --gui -- %command%

Just to confirm, is ludusavi_rCURRENT.log also an old one? If so, that implies Steam isn't even able to launch Ludusavi, which does probably sound like some Flatpak permissions thing (even more so if Steam itself is in a Flatpak as well).

njdom24 commented 3 months ago

Seeing the same behavior on NixOS. Running steam via terminal and running a game with ludusavi in the launch options also seemingly doesn't output anything.

mtkennerly commented 3 months ago

@njdom24 Could you try the test I mentioned in https://github.com/mtkennerly/ludusavi/issues/358#issuecomment-2179727414 ?

njdom24 commented 3 months ago

Still no good, I'm afraid. For what it's worth, both my system package, and the standalone binary you linked can run from Steam's launch options (e.g. ludusavi && %command%), but once wrap --gui is involved, it fails instantly without logging. Removing --gui does produce a log with the expected "not a terminal" error.

The nixpkg for Ludusavi does contain zenity and kdialog as dependencies, and I was able to confirm the dialog works outside of Steam.

mtkennerly commented 2 months ago

Thanks for checking. I'm not sure why it's not working, but I'll try to set up a system with Flatpak and see if I can figure something out.

NL-TCH commented 1 month ago

Hey @mtkennerly, Any update on this?

mtkennerly commented 1 month ago

@NL-TCH Hey, I finally set up a system to test this on. I did fix a couple of related issues (--infer steam using the wrong case to find the env var, and --force potentially hanging while waiting for input), but I haven't managed to figure out why --gui doesn't work yet. From the logs, Ludusavi tries to show the dialog, but it thinks that the user immediately selects no. It happens even with a standalone copy of Ludusavi, so it's not exclusively a Flatpak issue. I'll do some more testing and maybe explore alternative dialog options if needed.

If you're interested in the other fixes, you can try this build: ludusavi-v0.25.0-post.15+b2926a4-linux.zip