search

mtoensing / Docker-Minecraft-Bedrock-Server

Starts a Minecraft BEDROCK Server (PE Pocket Edition) for iOS, iPhone, iPad, XBOX and Windows.
https://hub.docker.com/r/marctv/minecraft-bedrock-server
MIT License
55 stars 9 forks source link

`whitelist.json` will be deprecated. Please migrate to `allowlist.json`. #31

Closed pichfl closed 2 years ago

pichfl commented 2 years ago

Hi! Thanks for this clean Docker image! I noticed that deprecation warning when booting up the current iteration of the server.

It should be possible to add some conditional code which checks if people still have whitelist.json and migrate them automatically or letting them keep the file around, symlinking it instead if no allowlist.json is found.

mtoensing commented 2 years ago

To be honest I have no idea to to migrate that automatically. If somebody has a great idea feel free to send pull request.

pichfl commented 2 years ago

That was quick 😄 I guess being in the same timezone for once helps quite a bit.

Anyway, I think I made it out to be much more complicated than it needs to be. I think all that needs to be done is to adjust the instructions and replace whitelist.json with allowlist.json and having a small upgrade instruction (shutdown container, rename, adjust the file path in the docker settings and be done with it)

mtoensing commented 2 years ago

I think the server will use the empty allowlist.json if I just rename the file. That might be a problem.

pichfl commented 2 years ago

I'll investigate later 👍

mtoensing commented 2 years ago

maybe some can come up with a script that moves the whitelist.json

mtoensing commented 2 years ago

I hope this is fixed with this commit https://github.com/mtoensing/Docker-Minecraft-Bedrock-Server/commit/041ff382d836cae91c5e743b3fbb8185a3a24413