search

mtoensing / wp-tgdb-importer

A 'The Game Database Importer' for Wordpress.
http://SHORTSCORE.org
2 stars 3 forks source link

About updating from api to json! " #3

Open meugamer opened 6 years ago

meugamer commented 6 years ago

Hello Marc, how are you? Do you want to update the api to the new version of the site?

mtoensing commented 6 years ago

Do you use my importer yourself?

meugamer commented 6 years ago

Yes! I even managed to switch to legacy. However, it is obsolete. The json api version of them I found the documentation a little confusing and without much explanation.

meugamer commented 6 years ago

So I asked if you plan on upgrading to the new version of them that is by api-key.

mtoensing commented 6 years ago

Until now I do not plan to integrate the new api. Can I have a look at your code? Is it a fork of my plugin? Maybe I can help

meugamer commented 6 years ago

I changed the urls to legacy. However, it does try to import the games when we try to import again. It only imports the same games and says it already exists. private $timeout = 30;

protected $apiUrl = 'http://legacy.thegamesdb.net/api/';
        $call = wp_remote_get('http://legacy.thegamesdb.net/api/GetPlatformsList.php');
meugamer commented 6 years ago

Hi, Marc. I saw that you updated api. However, I encountered an error importing the game by id. And on the line:   Parameter must be an array or an object that implements Countable, wp-tgdb-importer-master / marctv-tgdb-importer.php on line 770. Using php 7.2. Thanks for the update. Could you explain why it is not possible to import new games when it is limited to ten items per import? legacy.thegamesdb.net/api/%20.%20GetGame.php? image

mtoensing commented 6 years ago

Hi,

Can you fork this repository and fix it? I am very busy at the moment and will merge it right away. Then we can look into moving to the JSON api

meugamer commented 6 years ago

Fixed, it was an extra space on line 577 =).

mtoensing commented 6 years ago

Great. Can you send me a pull request?

meugamer commented 6 years ago

ok ok =).

mtoensing commented 6 years ago

Did you send me a pull request?

meugamer commented 6 years ago

I already sent it! Did not receive the notification? =).

mtoensing commented 6 years ago

Nope.

On Thu 20. Sep 2018 at 15:24, meugamer notifications@github.com wrote:

I already sent it! Did not receive the notification? =).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/mtoensing/wp-tgdb-importer/issues/3#issuecomment-423181519, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIWIR2ybfmLEGfm3pPRqz7PT5Gy16ohks5uc5b5gaJpZM4WWyCG .

-- Marc Tönsing mobile +49 176 20161260 blog http://www.marc.tv

meugamer commented 6 years ago

I resent it!

meugamer commented 6 years ago

Marc, I saw that you have the SHORTSCORES plugin. One time I tried to use it. However, he did not have the language for Portuguese. And I read your article that you're deactivating the system. Have you thought about creating it as a plugin for game review? Instead of using the direct api review. The person can put his own note using his plugin., In the same way that wp-review does? I think your plugin would be much more used. And I can still indicate in the forums of the brazilian sites. Since Brazilians use wordpress for website development a lot!

mtoensing commented 6 years ago

Hi @meugamer

I still can't find any pull request https://github.com/mtoensing/wp-tgdb-importer/pulls

You can localize my SHORTSCORE WP Plugin: https://github.com/mtoensing/wp-shortscore localisation is supported by PO and MO files. You can translate it with software like "poedit" and send me a - guess what - a pull request in that repository. =)