search

mtojek / greenwall

Tiny service health dashboard written in Go
MIT License
291 stars 27 forks source link

add docker support #12

Open llitfkitfk opened 5 years ago

mtojek commented 5 years ago

Hi @llitfkitfk

Thank you very much for your input! Shall I ask you to fix the Travis build as well?

mtojek commented 5 years ago

Another comment, any reason why you've enabled "go mod"? I wouldn't say no, but not as a part of this PR.

llitfkitfk commented 5 years ago

go mod for docker build download dependencies and build greenwall command

llitfkitfk commented 5 years ago

if some dependencies have breaking changes, docker build could be failed I think

mtojek commented 5 years ago

Generally l'm fine with your changes, but please fix the build on Travis, then I will merge it. Thanks!

llitfkitfk commented 5 years ago

I think go mod need added the first time

mtojek commented 5 years ago

Ok @llitfkitfk, so kindly please prepare a PR (with go mod only) that passes the Travis build.

BTW Later on, you can update README file with section about Docker.