search

mtolhuys / laravel-schematics

A Laravel package making a diagram of your models, relations and the ability to build them with it
MIT License
1.49k stars 133 forks source link

Add laravel 8 support (fix cases where namespace is in models) #58

Closed Dennis-Mwea closed 3 years ago

mtolhuys commented 3 years ago

First of all: thank you very much for your contribution @Dennis-Mwea ! I'll look at it asap.

Dennis-Mwea commented 3 years ago

@mtolhuys What's the progress on this?

mtolhuys commented 3 years ago

@Dennis-Mwea unfortunately TravisCI is not supporting open source projects anymore which would've shown the tests are failing on < php-8.0 projects. I've tried the changes in some projects where I have the package installed and had issues there. So I'm looking into a way to implement your fixes while keeping it working for projects running lower php versions as well.

The problem occurs in the collection of models and their relations and has to do with the concatenation of the namespace and the model classname.