search

mtolly / onyx

Toolkit for converting and building songs for Rock Band, Guitar Hero, Clone Hero, and other similar rhythm games
159 stars 16 forks source link

Vocal phrase length issue #131

Open mtolly opened 5 years ago

mtolly commented 5 years ago

https://pastebin.com/KATPy73f https://public.fightthe.pw/rehosts/acai/System%20of%20a%20Down%20-%20B.Y.O.B.zip

Error is the unhelpful

ERROR: MIDI Compiler: (PART VOCALS): Confused by vocal phrase overlap around [9:1:479]

but the issue is that apparently vocal phrases need to be at least 1 beat (480 ticks). The phrase in question is 479 ticks.

patriot1889 commented 4 years ago

Any thoughts on this? Have a big bunch of files I'm trying to convert that keep getting hit by this.

JohnSmith2007 commented 4 years ago

Any thoughts on this? Have a big bunch of files I'm trying to convert that keep getting hit by this.

Sorry, Dude. But I'm still very new to creating customs, and have only just gotten started on charting stuff for vocals. So I don't know that much. I'd recommend that you show this error message in the Authoring section on the C3 Discord. Somebody might be able to help you out there.

mtolly commented 4 years ago

@patriot1889 Can you post links to the files affected by this?

patriot1889 commented 4 years ago

@patriot1889 Can you post links to the files affected by this?

I have uploaded two to here; https://mega.nz/#F!Pw4AGagY!NNcImhewzAKuUKuZWy946A

I currently have 174 that error out, these are just two selected at random. If you need more let me know.

mtolly commented 4 years ago

Alright, @patriot1889 I think I have some code that fixes the issues in Born to Run (both the vocal phrase issue above, and a separate issue with drums). I'll try to get a release out with those as soon as I can.

The other song you posted, the GHL Biffy Clyro song, I don't think I can convert the vocals -- it's getting different errors and looking at the MIDI it doesn't look usable as a RB chart. It has overlapping notes, and I'm not sure how they are supposed to be interpreted (or where they came from, if GHL actually had that data or if the person who converted it added it?) What you can do, if you are only looking to convert the guitar part, is to uncheck the Vocals box at the bottom of the import window so it will not attempt to use it, like so:

Screenshot from 2020-03-29 00-59-35

patriot1889 commented 4 years ago

Ah, that’s great news! Thanks for working on that.

I look forward to testing out the new version and seeing how many it fixes. I may indeed just disable vocals on the others that don’t work like you suggested.