mtolly / onyx

Toolkit for converting and building songs for Rock Band, Guitar Hero, Clone Hero, and other similar rhythm games
154 stars 15 forks source link

Pro drums charts with no tom markers get marked all toms at converting PS/CH to rb3con #233

Open GeeForce11 opened 1 year ago

GeeForce11 commented 1 year ago

If a pro drums chart doesn't have any tom markers Onyx marks with 3 long tom markers on the whole length of the midi making all notes toms when converting to rb3con No toms: no tom Converted to rb3con all toms: all tom Some tom markers get converted properly: some tom

GeeForce11 commented 6 months ago

BUMP At least it should be optional if the author would like to mark all the drum notes as toms in case of a legacy drums chart, but doesn't make sense to mark them all automatically if there's no tom marker in a chart. I personally prefer to play any legacy drums chart on cymbals even by playing those few notes that were supposed to be toms on cymbals rather than being forced to play every single note on toms. There's also an option in RB3 to play a legacy drums chart as drums (all toms) or pro (cymbals) leaving it to the player to decide There's a workaround by deleting the tom markers from the converted CON midi and swapping it back into the CON