search

mtomwing / pickups

IRC gateway for hangups
MIT License
73 stars 25 forks source link

Use hostmasks for PRIVMSGs, reply to server PINGs, fixes #2

Closed GermainZ closed 9 years ago

GermainZ commented 9 years ago
  1. Send new lines as new messages. Multiline messages currently get corrupted. The first line is sent correctly, but the second is sent as is (without being formatted for IRC) and is not understood by the client.
  2. Hostmasks for PRIVMSGs. This seems to be the standard and allows ignoring people or similar without conflicts, especially if the first name is used instead of the full name (requires a manual edit).
  3. Reply to PING requests. This is so clients don't disconnect every now and then, when pickups doesn't reply to PING messages.
  4. Segmentize messages correctly. Links aren't clickable without this.
mtomwing commented 9 years ago

Thanks for the PR @GermainZ! Other than a few minor knit-picks, I see no reason not to merge this once those are addressed.

GermainZ commented 9 years ago

Ah, sorry -- should have double checked my commit. :) I think all issues are fixed now.

Would the client's PING message include this information? If so I think it would be better to get it from there.

Not unless I'm misunderstanding the RFC:

 Command: PONG

Parameters: [ ]

PONG message is a reply to ping message. If parameter is given, this message MUST be forwarded to given target. The parameter is the name of the entity who has responded to PING message and generated this message.

Reading that again, though, I think self.swrite('PONG', 'localhost', ':localhost') can be simplified to self.swrite('PONG', 'localhost').

mtomwing commented 9 years ago

Sorry it took so long to merge this, had to find time to actually run it :) Thanks for the contribution!